Skip to content

recorder: hive cell (recorder & rest api handler) #33114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2024
Merged

recorder: hive cell (recorder & rest api handler) #33114

merged 3 commits into from
Jun 14, 2024

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Jun 13, 2024 •
edited
Loading

This PR introduces a new Hive Cell for the PCAP recorder that provides the recorder and the corresponding rest api handler.

@mhofstetter mhofstetter added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. area/modularization Relates to code modularization and maintenance. labels Jun 13, 2024
@mhofstetter mhofstetter changed the title recorder: hive cell recorder: hive cell (recorder & rest api handler) Jun 13, 2024
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review June 13, 2024 10:16
@mhofstetter mhofstetter requested review from a team as code owners June 13, 2024 10:16
ldelossa
ldelossa approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhofstetter mhofstetter force-pushed the pr/mhofstetter/recorder-cell branch from fdb37ad to a37a8a0 Compare June 14, 2024 07:29
@mhofstetter
Copy link
Member Author

rebased to main to get some fixes for Gateway API checks.

@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 14, 2024
@mhofstetter
recorder: introduce cell for recorder
38a4290 
This commit introduces a hive cell for the pcap recorder.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter
recorder: use hive injected logger
0466a49 
This commit replaces the static logger with the one that has been
injected via Hive Framework.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter
recorder: move API handler into cell
a977421 
Currently, the recordder API handler is implemented by the daemon.

This commit extracts the implementation and moves it into the recorder
hive cell.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/recorder-cell branch from a37a8a0 to a977421 Compare June 14, 2024 13:36
@mhofstetter
Copy link
Member Author

rebased to main to resolve conflicts.

@mhofstetter mhofstetter removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 14, 2024
@mhofstetter
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2024
@borkmann borkmann merged commit f174b5e into cilium:main Jun 14, 2024
@mhofstetter mhofstetter deleted the pr/mhofstetter/recorder-cell branch June 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/modularization Relates to code modularization and maintenance. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhofstetter @joamaki @dylandreimerink @ysksuzuki @ldelossa @borkmann