Skip to content

daemon: remove unused method GetOptions #33105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

daemon: remove unused method GetOptions #33105

merged 1 commit into from
Jun 13, 2024

Conversation

mhofstetter
Copy link
Member

This commit removes the unused method GetOptions() *option.IntOptions from the daemon.

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jun 12, 2024
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review June 12, 2024 20:41
@mhofstetter mhofstetter requested a review from a team as a code owner June 12, 2024 20:41
@mhofstetter mhofstetter requested a review from doniacld June 12, 2024 20:41
@mhofstetter mhofstetter removed the request for review from doniacld June 13, 2024 11:59
@aanm aanm enabled auto-merge June 13, 2024 12:05
@mhofstetter @aanm
daemon: remove unused method GetOptions
34c96d8 
This commit removes the unused method `GetOptions() *option.IntOptions`
from the daemon.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@aanm aanm force-pushed the pr/mhofstetter/daemon-rem-getoptions branch from 3fca8a9 to 34c96d8 Compare June 13, 2024 12:06
@aanm
Copy link
Member

aanm commented Jun 13, 2024

/test

@aanm aanm added this pull request to the merge queue Jun 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2024
Merged via the queue into cilium:main with commit bb0c48a Jun 13, 2024
@mhofstetter mhofstetter deleted the pr/mhofstetter/daemon-rem-getoptions branch June 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhofstetter @aanm @joamaki