Skip to content

Conversation

mhofstetter
Copy link
Member

Currently, the daemon implements the LRP API handler. With it comes the last dependency to the LRP manager from the daemon.

Therefore, this commit moves the LRP API handler from the daemon to the existing LRP hive cell and removes the dependency from the daemon to the LRP manager.

@mhofstetter mhofstetter added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. area/lrp Impacts Local Redirect Policy. area/modularization Relates to code modularization and maintenance. labels Jun 12, 2024
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review June 13, 2024 10:13
@mhofstetter mhofstetter requested review from a team as code owners June 13, 2024 10:13
Currently, the daemon implements the LRP API handler. With it
comes the last dependency to the LRP manager from the daemon.

Therefore, this commit moves the LRP API handler from the daemon
to the existing LRP hive cell and removes the dependency from the
daemon to the LRP manager.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/lrp-api-handler branch from c4f7fe3 to 5dc2152 Compare June 14, 2024 07:22
@mhofstetter
Copy link
Member Author

rebased to main to get some fixes for Gateway API checks.

@mhofstetter
Copy link
Member Author

/test

@mhofstetter
Copy link
Member Author

Removing review-request for @ldelossa as we already have coverage for sig-agent with @joamaki 's review 🎉

@mhofstetter mhofstetter removed the request for review from ldelossa June 14, 2024 11:17
@mhofstetter mhofstetter added dont-merge/blocked Another PR must be merged before this one. and removed dont-merge/blocked Another PR must be merged before this one. labels Jun 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2024
@mhofstetter mhofstetter added dont-merge/blocked Another PR must be merged before this one. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. dont-merge/blocked Another PR must be merged before this one. labels Jun 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2024
@dylandreimerink dylandreimerink added this pull request to the merge queue Jun 14, 2024
Merged via the queue into cilium:main with commit 96336a0 Jun 14, 2024
@mhofstetter mhofstetter deleted the pr/mhofstetter/lrp-api-handler branch June 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lrp Impacts Local Redirect Policy. area/modularization Relates to code modularization and maintenance. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants