gha: Add more flags for Ingress Conformance test #33185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to mainly pick up the below changes cilium/ingress-controller-conformance#2 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to add enable-http-debug flag to capture more information in case of failure. Additionally, the stop-on-failure flag is added for faster feedback. Signed-off-by: Tam Mach <tam.mach@cilium.io>
|
/ci-ingress |
|
/test |
nebril
approved these changes
Jun 17, 2024
youngnick
reviewed
Jun 17, 2024
| -wait-time-for-ingress-status 60s \ | ||
| -wait-time-for-ready 60s \ | ||
| -enable-http-debug \ | ||
| -stop-on-failure |
There was a problem hiding this comment.
Hmm, do we want to stop on failure? I guess it's probably more likely we'll fail everything, but it would be handy to know if we only fail one of the tests...
There was a problem hiding this comment.
Ideally, yes, we would love to run all the tests by default, and see all failures at once. However, continue running other tests will automatically clean-up the failed test resources, which makes it hard to capture sysdump for further investigation.
Just a note that test here is actually feature in ingress conformance, we have only 4 tests/features in total.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #31857