Skip to content

dev-doctor: update hint links #33158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2024
Merged

dev-doctor: update hint links #33158

merged 1 commit into from
Jun 15, 2024

Conversation

renyunkang
Copy link
Contributor

@renyunkang renyunkang commented Jun 14, 2024 •
edited
Loading

Update hint links of golangci-lint.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
Update hint links of golangci-lint.

@renyunkang
dev-doctor: update hint links
a794220 
Signed-off-by: renyunkang <rykren1998@gmail.com>
@renyunkang renyunkang requested a review from a team as a code owner June 14, 2024 15:26
@renyunkang renyunkang requested a review from aditighag June 14, 2024 15:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 14, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 14, 2024
@renyunkang
Copy link
Contributor Author

/test

@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Jun 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 14, 2024
aditighag
aditighag approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aditighag
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2024
@renyunkang
Copy link
Contributor Author

Some e2e tests failed. Is there something wrong with e2e?

@aanm aanm added this pull request to the merge queue Jun 15, 2024
Merged via the queue into cilium:main with commit 268d28e Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renyunkang @aditighag @aanm