Skip to content

ci: fix ces migration test trigger and conn-disrupt usage #33147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2024
Merged

ci: fix ces migration test trigger and conn-disrupt usage #33147

merged 1 commit into from
Jun 15, 2024

Conversation

jshr-w
Copy link
Contributor

@jshr-w jshr-w commented Jun 13, 2024 •
edited
Loading

PR #32930 introduced a change to the conn-disrupt test that caused this migration test to fail. This PR updates the test to work with the updated test format. The inconsistency was not caught because of the path filters used in the test, so the path filters have been updated to exclude only Documentation/ and test/.

Fixes: #32268

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 13, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 13, 2024
@jshr-w jshr-w marked this pull request as ready for review June 13, 2024 22:49
@jshr-w jshr-w requested review from a team as code owners June 13, 2024 22:49
@jshr-w jshr-w requested a review from viktor-kurchenko June 13, 2024 22:49
giorio94
giorio94 requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall changes look good to me. Just a missing check to be added.

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jun 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 14, 2024
@jshr-w
ci: fix ces migration test trigger and conn-disrupt usage
306a446 
PR cilium#32930 introduced a change to the conn-disrupt test that caused this
migration test to fail. This PR updates the test to work with the
updated test format. The inconsistency was not caught because of the
path filters used in the test, so the path filters have been updated to
exclude only Documentation/ and test/.

Fixes: cilium#32268

Signed-off-by: jshr-w <shjayaraman@microsoft.com>
@jshr-w jshr-w force-pushed the jshr/fixcesmigtest branch from b34ff8e to 306a446 Compare June 14, 2024 16:50
@jshr-w jshr-w requested a review from giorio94 June 14, 2024 17:25
giorio94
giorio94 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aanm
Copy link
Member

aanm commented Jun 15, 2024

/test

@aanm aanm enabled auto-merge June 15, 2024 08:58
@aanm aanm added this pull request to the merge queue Jun 15, 2024
Merged via the queue into cilium:main with commit ffb8443 Jun 15, 2024
@pchaigno pchaigno added the feature/ces Impacts the Cilium Endpoint Slice logic. label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@giorio94 giorio94 giorio94 approved these changes

@viktor-kurchenko viktor-kurchenko Awaiting requested review from viktor-kurchenko viktor-kurchenko is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake feature/ces Impacts the Cilium Endpoint Slice logic. kind/community-contribution This was a contribution made by a community member. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jshr-w @aanm @giorio94 @pchaigno