Skip to content

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jun 13, 2024

Fix the recently introduced rangeForKey function leveraged by the etcdinit logic to only grant permissions to the given key, and not the full prefix starting with that key, when appropriate.

@giorio94 giorio94 added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/kvstore Impacts the KVStore package interactions. labels Jun 13, 2024
@giorio94 giorio94 requested a review from marseel June 13, 2024 14:32
@giorio94 giorio94 requested a review from a team as a code owner June 13, 2024 14:32
@giorio94
Copy link
Member Author

/test

Fix the recently introduced rangeForKey function leveraged by the
etcdinit logic to only grant permissions to the given key, and not
the full prefix starting with that key, when appropriate.

Fixes: cb6a58b ("clustermesh: granular etcd permissions for kvstoremesh cached data")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/kvstore-prefix branch from c6fe6e5 to 8b66954 Compare June 14, 2024 08:50
@giorio94 giorio94 changed the title kvstore: define prefix constants to include trailing slash kvstore: correctly assign permissions to single key, rather than prefix Jun 14, 2024
@giorio94 giorio94 removed the kind/cleanup This includes no functional changes. label Jun 14, 2024
@giorio94 giorio94 marked this pull request as ready for review June 14, 2024 08:50
@giorio94
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2024
@dylandreimerink dylandreimerink added this pull request to the merge queue Jun 14, 2024
Merged via the queue into cilium:main with commit aa10df3 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kvstore Impacts the KVStore package interactions. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants