Skip to content

endpoint: Place endpoints without bpf to endpoints map #33014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

endpoint: Place endpoints without bpf to endpoints map #33014

wants to merge 1 commit into from

Conversation

jrajahalme
Copy link
Member

Even endpoints without bpf programs or policy need ARP and IPv6 ND to work so that traffic can reach them. Place such endpoints in the bpf endpoints map (aka lxcmap).

This fixes missing IPv6 ND responses for the Ingress IPs.

Fixes: #32980

IPv6 ND responses are enabled for Ingress IPs.

@jrajahalme jrajahalme added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. area/agent Cilium agent related. area/servicemesh GH issues or PRs regarding servicemesh labels Jun 10, 2024
@jrajahalme jrajahalme requested a review from a team as a code owner June 10, 2024 14:32
@jrajahalme jrajahalme requested a review from aditighag June 10, 2024 14:32
@jrajahalme jrajahalme force-pushed the ingress-ip-endpoint-map branch from e641980 to a543b46 Compare June 10, 2024 14:32
@jrajahalme jrajahalme marked this pull request as draft June 10, 2024 14:32
@jrajahalme jrajahalme mentioned this pull request Jun 10, 2024
Closed
3 tasks
@jrajahalme jrajahalme force-pushed the ingress-ip-endpoint-map branch 2 times, most recently from a7baeab to cd35204 Compare June 10, 2024 19:43
@jrajahalme
Copy link
Member Author

/test

@julianwiedmann julianwiedmann mentioned this pull request Jul 1, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 11, 2024
@github-actions GitHub Actions
Copy link

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Jul 25, 2024
@jrajahalme jrajahalme reopened this Aug 5, 2024
@sayboras sayboras removed the request for review from aditighag August 5, 2024 14:34
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 6, 2024
@jrajahalme
endpoint: Place endpoints without bpf to endpoints map
b34b6ec 
Even endpoints without bpf programs or policy need ARP and IPv6 ND to
work so that traffic can reach them. Place such endpoints in the bpf
endpoints map (aka lxcmap).

This fixes missing IPv6 ND responses for the Ingress IPs.

Fixes: cilium#32980
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the ingress-ip-endpoint-map branch from cd35204 to b34b6ec Compare August 6, 2024 09:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 6, 2024
@github-actions GitHub Actions
Copy link

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Sep 20, 2024
@julianwiedmann julianwiedmann mentioned this pull request Sep 30, 2024
Merged
@jrajahalme
Copy link
Member Author

Superseded by #35143

@jrajahalme
Copy link
Member Author

Rebased before reopening, so could not reopen any more. New PR at #35143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/agent Cilium agent related. area/servicemesh GH issues or PRs regarding servicemesh kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium does not send ICMPv6 NA for reserved:ingress endpoints
1 participant
@jrajahalme