Skip to content

envoy: Remove un-necessary warning log filtering #33013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

envoy: Remove un-necessary warning log filtering #33013

merged 1 commit into from
Jun 12, 2024

Conversation

sayboras
Copy link
Member

Relates: #31108
Relates: envoyproxy/envoy#30735

@sayboras
envoy: Remove un-necessary warning log filtering
e584f43 
Relates: cilium#31108
Relates: envoyproxy/envoy#30735
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras requested a review from a team as a code owner June 10, 2024 13:35
@sayboras sayboras requested a review from jrajahalme June 10, 2024 13:35
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 10, 2024
@sayboras sayboras added kind/cleanup This includes no functional changes. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. labels Jun 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 10, 2024
@sayboras
Copy link
Member Author

/test

@sayboras sayboras enabled auto-merge June 11, 2024 07:05
@jrajahalme
Copy link
Member

We still set these runtime keys, is Envoy no longer logging these as deprecated?

@sayboras sayboras added this pull request to the merge queue Jun 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 12, 2024
Merged via the queue into cilium:main with commit 973d540 Jun 12, 2024
@sayboras sayboras deleted the pr/tammach/cleanup-envoy-warning branch June 12, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayboras @jrajahalme