Skip to content

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Jun 10, 2024

In these workflows, we used a specific cluster name for kops. Cilium-cli fetched the cluster name from context resulting in a validation error.

In these workflows we used specific cluster name for kops.
Cilium-cli fetched cluster name from context resulting in validation
error.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 10, 2024
@marseel
Copy link
Contributor Author

marseel commented Jun 10, 2024

/fqdn-perf

@marseel marseel added the release-note/ci This PR makes changes to the CI. label Jun 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 10, 2024
@marseel marseel requested review from giorio94 and brlbil June 10, 2024 11:00
@marseel
Copy link
Contributor Author

marseel commented Jun 10, 2024

/test

@marseel
Copy link
Contributor Author

marseel commented Jun 10, 2024

Passing test for fqdn: https://github.com/cilium/cilium/actions/runs/9446581281

@marseel marseel marked this pull request as ready for review June 10, 2024 11:01
@marseel marseel requested review from a team as code owners June 10, 2024 11:01
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marseel
Copy link
Contributor Author

marseel commented Jun 10, 2024

/ci-multi-pool

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 10, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 10, 2024
@julianwiedmann julianwiedmann added the area/CI Continuous Integration testing issue or flake label Jun 10, 2024
Merged via the queue into main with commit 6a0d178 Jun 10, 2024
@julianwiedmann julianwiedmann deleted the pr/marseel/fix_kops_workflows branch June 10, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants