Skip to content

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jun 12, 2024

It seems like github runner is enabled with docker dual stack, so the
current docker network inspect command might return IPv6 instead of
IPv4 CIDR, which breaks LB IPPool configuration. Sample output of
docker network inspect kind command can be found as per below.

This commit is to make sure that we only retrieve IPv4 CIDR in docker
network inspect command. Additionally, some echo/cat statement are added
to make similar issue more visible in the future.

[
    {
        "Name": "kind",
        "Id": "43e3b3267092150f5f2e6f2053157d912ad6b5a4ce20f700e1e9be547a437f75",
        "Created": "2024-06-12T14:18:17.733107881Z",
        "Scope": "local",
        "Driver": "bridge",
        "EnableIPv6": true,
        "IPAM": {
            "Driver": "default",
            "Options": {},
            "Config": [
                {
                    "Subnet": "fc00:f853:ccd:e793::/64"
                },
                {
                    "Subnet": "172.18.0.0/16",
                    "Gateway": "172.18.0.1"
                }
            ]
        },
        "Internal": false,
        "Attachable": false,
        "Ingress": false,
        "ConfigFrom": {
            "Network": ""
        },
        "ConfigOnly": false,
        "Containers": {
            "748d7161857ca5e610f196299828eacafcbdb069d38c00e4e6c14cdeefada9c5": {
                "Name": "chart-testing-control-plane",
                "EndpointID": "0f1a5bbeb14929200ed13cb289afd6bf5f9f455d4ed75bb3a26e167e67bf7784",
                "MacAddress": "02:42:ac:12:00:02",
                "IPv4Address": "172.18.0.2/16",
                "IPv6Address": "fc00:f853:ccd:e793::2/64"
            },
            "c2030425e24a11ea208b87c5d70e194b0f51eee133f09b67404fd2bf97410f13": {
                "Name": "chart-testing-worker",
                "EndpointID": "81489bd101e483be7270e2b5dd7e0bf3a0163b89650d7ef69cc4ce43454479e3",
                "MacAddress": "02:42:ac:12:00:03",
                "IPv4Address": "172.18.0.3/16",
                "IPv6Address": "fc00:f853:ccd:e793::3/64"
            }
        },
        "Options": {
            "com.docker.network.bridge.enable_ip_masquerade": "true",
            "com.docker.network.driver.mtu": "1500"
        },
        "Labels": {}
    }
]

@maintainer-s-little-helper
Copy link

Commit df59f5a does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 12, 2024
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/dummy-commit-ci branch from df59f5a to 9f8f67f Compare June 12, 2024 13:37
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 12, 2024
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/dummy-commit-ci branch from 9f8f67f to e4673f0 Compare June 12, 2024 14:10
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/dummy-commit-ci branch from e4673f0 to 5f42755 Compare June 12, 2024 14:17
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/dummy-commit-ci branch 2 times, most recently from 19a764d to b21237f Compare June 12, 2024 14:43
@sayboras sayboras changed the title dummy commit to test CI gha: Only retrieve IPv4 CIDR from docker network Jun 12, 2024
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Jun 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 12, 2024
@sayboras
Copy link
Member Author

/test

It seems like github runner is enabled with docker dual stack, so the
current docker network inspect command might return IPv6 instead of
IPv6 CIDR, which breaks LB IPPool configuration. Sample output of
`docker network inspect kind` command can be found as per below.

This commit is to make sure that we only retrieve IPv4 CIDR in docker
network inspect command. Additionally, some echo/cat statement are added
to make similar issue more visible in the future.

```
[
    {
        "Name": "kind",
        "Id": "43e3b3267092150f5f2e6f2053157d912ad6b5a4ce20f700e1e9be547a437f75",
        "Created": "2024-06-12T14:18:17.733107881Z",
        "Scope": "local",
        "Driver": "bridge",
        "EnableIPv6": true,
        "IPAM": {
            "Driver": "default",
            "Options": {},
            "Config": [
                {
                    "Subnet": "fc00:f853:ccd:e793::/64"
                },
                {
                    "Subnet": "172.18.0.0/16",
                    "Gateway": "172.18.0.1"
                }
            ]
        },
        "Internal": false,
        "Attachable": false,
        "Ingress": false,
        "ConfigFrom": {
            "Network": ""
        },
        "ConfigOnly": false,
        "Containers": {
            "748d7161857ca5e610f196299828eacafcbdb069d38c00e4e6c14cdeefada9c5": {
                "Name": "chart-testing-control-plane",
                "EndpointID": "0f1a5bbeb14929200ed13cb289afd6bf5f9f455d4ed75bb3a26e167e67bf7784",
                "MacAddress": "02:42:ac:12:00:02",
                "IPv4Address": "172.18.0.2/16",
                "IPv6Address": "fc00:f853:ccd:e793::2/64"
            },
            "c2030425e24a11ea208b87c5d70e194b0f51eee133f09b67404fd2bf97410f13": {
                "Name": "chart-testing-worker",
                "EndpointID": "81489bd101e483be7270e2b5dd7e0bf3a0163b89650d7ef69cc4ce43454479e3",
                "MacAddress": "02:42:ac:12:00:03",
                "IPv4Address": "172.18.0.3/16",
                "IPv6Address": "fc00:f853:ccd:e793::3/64"
            }
        },
        "Options": {
            "com.docker.network.bridge.enable_ip_masquerade": "true",
            "com.docker.network.driver.mtu": "1500"
        },
        "Labels": {}
    }
]
```

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/dummy-commit-ci branch from b21237f to 572bc3e Compare June 12, 2024 15:05
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review June 12, 2024 15:14
@sayboras sayboras requested review from a team as code owners June 12, 2024 15:14
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sayboras sayboras added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit b49f912 Jun 12, 2024
@sayboras sayboras deleted the pr/tammach/dummy-commit-ci branch June 12, 2024 22:30
@giorio94 giorio94 mentioned this pull request Jun 13, 2024
1 task
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Jun 13, 2024
@giorio94 giorio94 mentioned this pull request Jun 13, 2024
1 task
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Jun 13, 2024
@giorio94 giorio94 mentioned this pull request Jun 13, 2024
1 task
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jun 13, 2024
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Backport done to v1.14
Status: Backport done to v1.15
Development

Successfully merging this pull request may close these issues.

3 participants