Skip to content

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Jun 12, 2024

There was a significant flakiness of IPSec-related privileged tests due to the fact that tests in different packages were modifying xfrm states/policies concurrently.

While increasing timeout for test and making it last longer is non-ideal, less flaky tests outweigh it.
The observed increase in time of test: from ~20 minutes to ~30 minutes.

Related: #32902
Related: #32954

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 12, 2024
@marseel
Copy link
Contributor Author

marseel commented Jun 12, 2024

/ci-runtime

@marseel marseel force-pushed the pr/marseel/fix_runtime_tests branch from 83cf4e2 to 66890cb Compare June 12, 2024 13:59
@marseel
Copy link
Contributor Author

marseel commented Jun 12, 2024

/test

@marseel marseel added the release-note/ci This PR makes changes to the CI. label Jun 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 12, 2024
@marseel marseel marked this pull request as ready for review June 12, 2024 15:09
@marseel marseel requested review from a team as code owners June 12, 2024 15:09
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There was a significant flakiness of IPSec-related privileged tests due
to the fact that tests in different packages were modifying xfrm
states/policies concurrently.

While increasing timeout for test and making it last longer is non-ideal,
less flaky tests outweight it.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/fix_runtime_tests branch from 66890cb to cae10b3 Compare June 13, 2024 09:44
@marseel
Copy link
Contributor Author

marseel commented Jun 13, 2024

Rebased to pick up ingress/gateway changes

@marseel
Copy link
Contributor Author

marseel commented Jun 13, 2024

/test

@aanm aanm enabled auto-merge June 13, 2024 12:44
@aanm aanm added this pull request to the merge queue Jun 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2024
Merged via the queue into main with commit 0c0800c Jun 13, 2024
@aanm aanm deleted the pr/marseel/fix_runtime_tests branch June 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants