Skip to content

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jun 12, 2024

Motivated by trimming down the wireguard.h usage.

@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jun 12, 2024
@julianwiedmann julianwiedmann requested a review from a team as a code owner June 12, 2024 11:02
@julianwiedmann julianwiedmann requested a review from jibi June 12, 2024 11:02
@julianwiedmann julianwiedmann enabled auto-merge June 12, 2024 11:02
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title bpf: encap: clean up some unneeded includes bpf: clean up some unneeded includes Jun 12, 2024
@julianwiedmann
Copy link
Member Author

/test

The include for l3.h is no longer needed since
3aa51eb ("bpf: ipsec: move get_min_encrypt_key() to encrypt.h"),
and the last wireguard usage went away with
b67291f ("bpf: Encap with cilium_{vxlan,geneve} before passing to WG").

This uncovered some implicit includes for hs-ipcache, fix them up.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
This probably is no longer needed since
81c45d2 ("bpf: Remove strict encrypt check from bpf_overlay").

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the 1.16-bpf-encap-cleanups branch from cad18a1 to 0ccce2b Compare June 13, 2024 05:06
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2024
Merged via the queue into cilium:main with commit fd0b235 Jun 13, 2024
@julianwiedmann julianwiedmann deleted the 1.16-bpf-encap-cleanups branch June 13, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants