bpf: lxc: fix ifindex in TO_ENDPOINT trace notification #33085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
86ba0c5 to
fe8684b
Compare
|
/test |
fe8684b to
b25cb8d
Compare
|
/ci-runtime |
|
/test |
|
Mind you that I have little clue about all the templating dance in the loader. So this might be totally bogus :). |
lmb
requested changes
Jun 13, 2024
b25cb8d to
7047c29
Compare
|
/test |
nebril
approved these changes
Jun 13, 2024
7047c29 to
9359224
Compare
|
/test |
|
(quick rebase to pick up healthy CI) |
Make the ifindex of an endpoint available to the attached BPF program, so that it can be used by a subsequent patch. We can most likely unify this later with NATIVE_DEV_IFINDEX, which is only provided for native devices. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
ipv*_policy() takes an `ifindex` parameter, and exclusively uses it to fill trace notifications. But for some cases the provided ifindex is currently 0 (for instance in a configuration with per-EP routing, when calling from to-container). Just provide the actual interface index instead. Reported-by: Tomasz Tarczyński <tomasz.tarczynski@isovalent.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
9359224 to
4201e60
Compare
|
/test |
|
(and one more to resolve a conflict in bpf_lxc) |
|
We don't need to pass CB_IFINDEX from l3_local_delivery anymore with this PR? Line 112 in 572bca4 |
ysksuzuki
approved these changes
Jun 19, 2024
I think we still need it to indicate whether the redirect should happen. But ack, it can be a boolean flag now. |
2 tasks
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert the ifindex of an endpoint into the
bpf_lxcprogram, so that we can use it for trace notifications.