Skip to content

docs: minor updates for Egress Gateway #33060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2024
Merged

docs: minor updates for Egress Gateway #33060

merged 1 commit into from
Jun 14, 2024

Conversation

julianwiedmann
Copy link
Member

Fully reflect #32828 in the docs.

@julianwiedmann julianwiedmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. feature/egress-gateway Impacts the egress IP gateway feature. labels Jun 11, 2024
@julianwiedmann julianwiedmann requested a review from ysksuzuki June 11, 2024 14:09
@julianwiedmann julianwiedmann requested review from a team as code owners June 11, 2024 14:09
@julianwiedmann julianwiedmann requested a review from qmonnet June 11, 2024 14:09
@julianwiedmann
Copy link
Member Author

@ysksuzuki maybe we should log/warn from the EGW manager if DNS proxy is not in transparent mode? Similar to feafd6d 😬.

@julianwiedmann
Copy link
Member Author

/test

ysksuzuki
ysksuzuki reviewed Jun 13, 2024
View reviewed changes
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2024
@julianwiedmann julianwiedmann added the dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. label Jun 13, 2024
@julianwiedmann
docs: egressgw: remove stale enable-l7-proxy option
8e84c4e 
This option was suggested to deal with an incompatibility between EGW and
L7 policies. The incompatibility has been addressed by
cilium#32828.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. labels Jun 14, 2024
@julianwiedmann julianwiedmann requested a review from ysksuzuki June 14, 2024 06:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2024
@ysksuzuki
Copy link
Member

Thanks!

@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 14, 2024
Merged via the queue into cilium:main with commit 8482b03 Jun 14, 2024
@julianwiedmann julianwiedmann deleted the 1.16-dns-proxy-docs branch June 14, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. feature/egress-gateway Impacts the egress IP gateway feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianwiedmann @ysksuzuki @qmonnet