Test: fix invalid network policies #32901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some tests that supplied invalid network policies. Fix them. Unfortunately, there is one disallowed case we would still like to test, so add an option to override that particular validation check in test mode. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
We were accidentally adding policies that did not pass validation. Rename the test-only function AddList to MustAddList, reject invalid policies. Add the additional helper addInvalidRules() which accepts invalid policies. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
This is a convenience test function, there's no need for it to be exported. The one external use is easily removed. Also, add a panic() to ensure tests do not accidentally rely on invalid data, which has happened in the past. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
|
/test |
nathanjsweet
approved these changes
Jun 5, 2024
|
The e2e failure (of which only one test out of 16 is failing) is understood and being addressed by the CI team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an oversight, the various test suites submitted invalid policies to the repository. We previously allowed this, but this has gotten us in to trouble.
So, fix all invalid policies and require that all testing policies be valid. Also, un-export some unused testing functions.