Skip to content

bgpv2: Allow empty advertisement #32997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

bgpv2: Allow empty advertisement #32997

merged 1 commit into from
Jun 12, 2024
+1 −3

Conversation

YutaroHayakawa
Copy link
Member

Remove unnecessary restriction.

bgpv2: Allow empty advertisement

@YutaroHayakawa
bgpv2: Allow empty advertisement
861afe8 
Remove unnecessary restriction.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 10, 2024
@YutaroHayakawa YutaroHayakawa added the release-note/misc This PR makes changes that have no direct user impact. label Jun 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 10, 2024
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review June 10, 2024 07:30
@YutaroHayakawa YutaroHayakawa requested a review from a team as a code owner June 10, 2024 07:30
@YutaroHayakawa
Copy link
Member Author

/test

@YutaroHayakawa YutaroHayakawa requested review from a team and rastislavs and removed request for a team June 10, 2024 07:30
rastislavs
rastislavs approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YutaroHayakawa YutaroHayakawa enabled auto-merge June 11, 2024 02:45
@YutaroHayakawa
Copy link
Member Author

Cilium E2E Upgrade: #32689

@YutaroHayakawa YutaroHayakawa added this pull request to the merge queue Jun 12, 2024
Merged via the queue into cilium:main with commit 22b3e82 Jun 12, 2024
@YutaroHayakawa YutaroHayakawa deleted the fix-advert branch June 12, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@aanm aanm aanm approved these changes

@rastislavs rastislavs rastislavs approved these changes

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YutaroHayakawa @gandro @aanm @rastislavs @harsimran-pabla