Skip to content

clustermesh: extract operator logic into a specific package #32979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

clustermesh: extract operator logic into a specific package #32979

merged 1 commit into from
Jun 17, 2024

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Jun 9, 2024 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This commit extracts all the clustermesh specific code into a package called operator. The aim of this is to provide clustermesh specific features to other package launched in the operator. The first user for this besides endpointslicesync would be the mcsapi package.

Related to #32712

Extract clustermesh logic in the operator in a generic package

@MrFreezeex MrFreezeex requested review from a team as code owners June 9, 2024 00:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 9, 2024
@MrFreezeex MrFreezeex force-pushed the separate-clustermesh-operator branch 11 times, most recently from d66b895 to 85a5f1f Compare June 9, 2024 11:08
@MrFreezeex MrFreezeex changed the title clustermesh: extract clustermesh logic into a specific package clustermesh: extract operator logic into a specific package Jun 9, 2024
@MrFreezeex MrFreezeex force-pushed the separate-clustermesh-operator branch from 85a5f1f to afdf852 Compare June 9, 2024 11:36
@MrFreezeex
Copy link
Member Author

/test

YutaroHayakawa
YutaroHayakawa requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Some small suggestions.

@MrFreezeex MrFreezeex force-pushed the separate-clustermesh-operator branch from afdf852 to d8e4ba7 Compare June 10, 2024 09:18
@MrFreezeex
Copy link
Member Author

/test

YutaroHayakawa
YutaroHayakawa reviewed Jun 12, 2024
View reviewed changes
@MrFreezeex MrFreezeex force-pushed the separate-clustermesh-operator branch 2 times, most recently from 150bb9c to 30e8984 Compare June 12, 2024 09:28
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex force-pushed the separate-clustermesh-operator branch 2 times, most recently from 37e07bf to 41741ad Compare June 12, 2024 09:40
@MrFreezeex
Copy link
Member Author

/test

@aanm aanm requested a review from giorio94 June 13, 2024 11:59
@giorio94 giorio94 added area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Jun 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 14, 2024
giorio94
giorio94 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, just a bunch of nits inline.

pippolo84
pippolo84 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus Marco's feedback. Thanks! 🙏

@MrFreezeex MrFreezeex force-pushed the separate-clustermesh-operator branch 2 times, most recently from b28b159 to 91e6ed9 Compare June 14, 2024 16:59
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex
Copy link
Member Author

/ci-gateway-api

@MrFreezeex
Copy link
Member Author

/ci-ipsec-e2e

@MrFreezeex
Copy link
Member Author

/ci-ingress

@MrFreezeex
Copy link
Member Author

/ci-gateway-api

@MrFreezeex
Copy link
Member Author

/ci-ipsec-e2e

@MrFreezeex
Copy link
Member Author

/ci-gateway-api

1 similar comment
@MrFreezeex
Copy link
Member Author

/ci-gateway-api

@MrFreezeex
clustermesh: extract operator logic into a specific package
9a3d1f3 
This commit extracts all the clustermesh specific code into a package
called operator. The aim of this is to provide clustermesh specific
features to other package launched in the operator. The first user for
this besides endpointslicesync would be the mcsapi package.

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@MrFreezeex MrFreezeex force-pushed the separate-clustermesh-operator branch from 91e6ed9 to 9a3d1f3 Compare June 15, 2024 11:46
@MrFreezeex
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 15, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 17, 2024
Merged via the queue into cilium:main with commit 72ffe0f Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@pippolo84 pippolo84 pippolo84 approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrFreezeex @pippolo84 @YutaroHayakawa @giorio94 @julianwiedmann