loader: cache parsed CollectionSpec #32962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
b7a14e0 to
14787f4
Compare
|
/test |
|
/test |
e9245d3 to
09dc6b9
Compare
|
/test |
09dc6b9 to
6a58849
Compare
|
/test |
bimmlerd
reviewed
Jun 10, 2024
6a58849 to
dd7269d
Compare
bimmlerd
approved these changes
Jun 11, 2024
|
@rgo3 @gentoo-root can you help me get this in before the freeze? 🙏 |
julianwiedmann
approved these changes
Jun 13, 2024
|
/test |
The object cache currently does no invalidation, which means that we accumulate cachedObject in memory and template ELF on disk. Use update of the base datapath hash as an opportunity to evict some of that cache. In practice this is probably not a big issue: datapath config changes rarely if every, and we only have templates for endpoints and host endpoint. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
The object cache parses an ELF from disk any time it is asked for a template. This is wasteful since parsing the ELF is quite resource intensive. Cache the parsed CollectionSpec instead. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
dd7269d to
c459aa8
Compare
|
/test |
1 similar comment
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loader: evict object cache when datapath config changes
loader: cache parsed CollectionSpec