Skip to content

pkg/identity: Move GetCIDKeyFromK8sLabels to GlobalIdentity #32960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2024
Merged

pkg/identity: Move GetCIDKeyFromK8sLabels to GlobalIdentity #32960

merged 1 commit into from
Jun 10, 2024

Conversation

ovidiutirla
Copy link
Contributor

Moves the method from ciliumidentity package to GlobalIdentity and makes the method more generic by accepting the source to be used in mapping.

Related #27752

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 7, 2024
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Jun 7, 2024
@ovidiutirla ovidiutirla marked this pull request as ready for review June 7, 2024 12:33
@ovidiutirla ovidiutirla requested review from a team as code owners June 7, 2024 12:33
@ovidiutirla ovidiutirla requested review from derailed and pippolo84 June 7, 2024 12:33
@ovidiutirla ovidiutirla force-pushed the feature/op-id-move-identity branch 2 times, most recently from 1701718 to bc47d87 Compare June 7, 2024 15:07
derailed
derailed approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovidiutirla Nice work!

@ovidiutirla ovidiutirla force-pushed the feature/op-id-move-identity branch 2 times, most recently from 9b9dd0e to 1b6992d Compare June 7, 2024 23:45
@cilium cilium deleted a comment Jun 8, 2024
@ovidiutirla
pkg/identity: Move GetCIDKeyFromK8sLabels to GlobalIdentity
374e78c 
Moves the method from ciliumidentity package to GlobalIdentity and makes
the method more generic by accepting the source to be used in mapping.

Related cilium#27752

Signed-off-by: Ovidiu Tirla <otirla@google.com>
@ovidiutirla ovidiutirla force-pushed the feature/op-id-move-identity branch from 1b6992d to 374e78c Compare June 8, 2024 10:46
@ovidiutirla
Copy link
Contributor Author

/test

pippolo84
pippolo84 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@pippolo84 pippolo84 added area/operator Impacts the cilium-operator component release-note/misc This PR makes changes that have no direct user impact. labels Jun 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 10, 2024
@sayboras sayboras added this pull request to the merge queue Jun 10, 2024
Merged via the queue into cilium:main with commit 5faea37 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@pippolo84 pippolo84 pippolo84 approved these changes

Assignees
No one assigned
Labels
area/operator Impacts the cilium-operator component ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ovidiutirla @derailed @pippolo84 @sayboras