Skip to content

Documentation: straight quotes to back quotes #32953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

Documentation: straight quotes to back quotes #32953

merged 1 commit into from
Jun 7, 2024

Conversation

hacktivist123
Copy link
Contributor

@hacktivist123 hacktivist123 commented Jun 7, 2024 •
edited by qmonnet
Loading

This PR removes the use of double straight quotes for back quotes when referring to commands and functions in the envoy.rst file

docs: Fix literals formatting in Envoy documentation by replacing straight quotes with back quotes

@maintainer-s-little-helper
Copy link

Commits 90ecbb2, 157be56 do not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 7, 2024
@hacktivist123
chore: replace straight quotes with backticks for commands and functions
b1a34d4 
Signed-off-by: Shedrack Akintayo <akintayoshedrack@gmail.com>
@hacktivist123 hacktivist123 force-pushed the documentation/straight-quotes-to-back-quotes branch from 157be56 to b1a34d4 Compare June 7, 2024 10:08
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 7, 2024
@hacktivist123 hacktivist123 marked this pull request as ready for review June 7, 2024 10:10
@hacktivist123 hacktivist123 requested review from a team as code owners June 7, 2024 10:10
@hacktivist123 hacktivist123 changed the title Documentation/straight quotes to back quotes Documentation: straight quotes to back quotes Jun 7, 2024
qmonnet
qmonnet approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 7, 2024
@qmonnet
Copy link
Member

qmonnet commented Jun 7, 2024

/test

@qmonnet
Copy link
Member

qmonnet commented Jun 7, 2024

This is a formatting fix, no need to wait for Marco's review. Merging now.

@qmonnet qmonnet added this pull request to the merge queue Jun 7, 2024
Merged via the queue into cilium:main with commit 6079830 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@mhofstetter mhofstetter Awaiting requested review from mhofstetter mhofstetter is a code owner automatically assigned from cilium/proxy

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacktivist123 @qmonnet