Skip to content

bpf: s/NODE_MAC/THIS_INTERFACE_MAC #32839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

bpf: s/NODE_MAC/THIS_INTERFACE_MAC #32839

merged 1 commit into from
Jun 5, 2024

Conversation

julianwiedmann
Copy link
Member

This value is not some generic, node-wide MAC address. Rather it is the MAC address of the specific interface that the BPF program is attached to.

Align the naming with the THIS_MTU macro.

@julianwiedmann
bpf: s/NODE_MAC/THIS_INTERFACE_MAC
74ab207 
This value is *not* some generic, node-wide MAC address. Rather it is the
MAC address of the specific interface that the BPF program is attached to.

Align the naming with the THIS_MTU macro.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. labels Jun 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 3, 2024
@julianwiedmann julianwiedmann added the release-note/misc This PR makes changes that have no direct user impact. label Jun 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 3, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review June 3, 2024 09:15
@julianwiedmann julianwiedmann requested review from a team as code owners June 3, 2024 09:15
@julianwiedmann julianwiedmann requested review from rgo3 and aditighag June 3, 2024 09:15
aditighag
aditighag approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2024
@aditighag aditighag added this pull request to the merge queue Jun 5, 2024
Merged via the queue into cilium:main with commit 7dbd76c Jun 5, 2024
@julianwiedmann julianwiedmann deleted the 1.16-bpf-node-mac branch May 9, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgo3 rgo3 rgo3 approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianwiedmann @rgo3 @aditighag