helm: allow configuring the clustermesh-apiserver storage medium #32823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clustermesh-apiserver's etcd sidecar instance is by design stateless, as etcd data is stored in an emptyDir Kubernetes volume and not preserved upon restarts. Yet, let's expose to users the medium config, to allow creating a volume backed by RAM rather than node storage. This allows for greatly improved etcd read and write performance at the cost of additional memory usage, which counts against the memory limits of the container. Additional information is available in the upstream documentation [1]. [1]: https://kubernetes.io/docs/concepts/storage/volumes/#emptydir Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
thorn3r
approved these changes
May 31, 2024
Yep, I don't see a reason either, as etcd by itself already limits the maximum storage size (2GB by default); introducing external limits would most likely lead to very confusing behavior. |
squeed
approved these changes
Jun 3, 2024
youngnick
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clustermesh-apiserver's etcd sidecar instance is by design stateless, as etcd data is stored in an emptyDir Kubernetes volume and not preserved upon restarts. Yet, let's expose to users the medium config, to allow creating a volume backed by RAM rather than node storage. This allows for greatly improved etcd read and write performance at the cost of additional memory usage, which counts against the memory limits of the container. Additional information is available in the upstream documentation [1].
[1]: https://kubernetes.io/docs/concepts/storage/volumes/#emptydir