images: Regenerate api/v1 when updating builder #32804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Marking as draft until #32767 goes in, then we can rebase + re-generate the builder image versions since the make script is an input to the builder. |
rolinh
approved these changes
May 31, 2024
ad42f65 to
a0d960e
Compare
|
/test |
ff3984a to
697dcfb
Compare
43cadb6 to
4a55ab9
Compare
4a55ab9 to
890850d
Compare
|
New step works in the workflow when testing with |
c53a34b to
bfbe220
Compare
|
/test |
rolinh
approved these changes
Jun 7, 2024
brlbil
approved these changes
Jun 7, 2024
The builder image contains the 'protoc' binary which can generate different API files when it's updated, notably because protoc decides to encode its own version into the files it outputs. Add a step in the builder image update workflow to update the api/v1 files. Signed-off-by: Joe Stringer <joe@cilium.io>
This error message was copied from the equivalent runtime script. Fix it. Signed-off-by: Joe Stringer <joe@cilium.io>
bfbe220 to
fbb5b16
Compare
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
|
/test |
aditighag
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builder image contains the 'protoc' binary which can generate
different API files when it's updated, notably because protoc decides to
encode its own version into the files it outputs.
Add a step in the builder image workflow to update the api/v1 files.
Related: #32767 (comment)