Skip to content

bgp/configmap: remove unnecessary else statement #32892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

bgp/configmap: remove unnecessary else statement #32892

merged 1 commit into from
Jun 6, 2024

Conversation

harsimran-pabla
Copy link
Contributor

Making BGP config-map settings similar to how rest of the feature flags are deduced.

@harsimran-pabla
bgp/configmap: remove unnecessary else statement
ab11011 
Making BGP config-map settings similar to how rest of the feature flags
are deduced.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla added the release-note/misc This PR makes changes that have no direct user impact. label Jun 4, 2024
@harsimran-pabla harsimran-pabla requested review from a team and rastislavs and removed request for a team June 4, 2024 19:52
rastislavs
rastislavs approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsimran-pabla harsimran-pabla marked this pull request as ready for review June 5, 2024 13:47
@harsimran-pabla harsimran-pabla requested review from a team as code owners June 5, 2024 13:47
@gandro
Copy link
Member

gandro commented Jun 6, 2024

/test

@harsimran-pabla
Copy link
Contributor Author

ci-integration : #32903

@harsimran-pabla
Copy link
Contributor Author

ci-ingress : #31857

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 6, 2024
@julianwiedmann julianwiedmann added the area/bgp Impacts the Border Gateway Protocol feature. label Jun 6, 2024
Merged via the queue into cilium:main with commit 4ee8ae5 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@youngnick youngnick youngnick approved these changes

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harsimran-pabla @gandro @youngnick @rastislavs @julianwiedmann