Skip to content

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jun 4, 2024

Relates: 4121a2f

Just a note that I am working on Gateway API 1.1.0 support, so will enable this test again in #32233

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 4, 2024
@sayboras
Copy link
Member Author

sayboras commented Jun 4, 2024

/ci-gateway-api

@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Jun 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 4, 2024
@sayboras
Copy link
Member Author

sayboras commented Jun 4, 2024

/ci-gateway-api

1 similar comment
@sayboras
Copy link
Member Author

sayboras commented Jun 4, 2024

/ci-gateway-api

@sayboras sayboras force-pushed the pr/tammach/gwapi-skip-tests branch from ed0328b to 73783cf Compare June 4, 2024 15:20
@sayboras
Copy link
Member Author

sayboras commented Jun 4, 2024

/ci-gateway-api

This commit is to skip MeshConsumerRoute related test, just a note that
Gateway API 1.0.0 didn't have MeshConsumerRoute feature flag, so we need
to use HTTPRouteResponseHeaderModification instead.

Relates: 4121a2f

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/gwapi-skip-tests branch from 73783cf to e6c32f9 Compare June 4, 2024 15:56
@sayboras
Copy link
Member Author

sayboras commented Jun 4, 2024

/ci-gateway-api

@sayboras sayboras marked this pull request as ready for review June 4, 2024 15:57
@sayboras sayboras requested review from a team as code owners June 4, 2024 15:57
@sayboras sayboras requested review from mhofstetter and brlbil June 4, 2024 15:57
@sayboras
Copy link
Member Author

sayboras commented Jun 4, 2024

/test

@aanm aanm added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 8de7a90 Jun 4, 2024
@aanm aanm deleted the pr/tammach/gwapi-skip-tests branch June 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants