Skip to content

Conversation

mhofstetter
Copy link
Member

This commit cleans up the fields from the daemon and daemonParams
struct:

  • EgressGatewayManager (unused - removed from daemon and daemonParams)
  • HealthProvider (unused - removed from daemon and daemonParams)
  • DeviceManager (keep in daemonParams)
  • EndpointManager (set when initializing daemon struct)

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/agent Cilium agent related. labels Jun 4, 2024
@mhofstetter mhofstetter changed the title k8s: cleanup daemon fields daemon: cleanup daemon fields Jun 4, 2024
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review June 4, 2024 13:49
@mhofstetter mhofstetter requested a review from a team as a code owner June 4, 2024 13:49
@mhofstetter mhofstetter requested a review from ldelossa June 4, 2024 13:49
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit cleans up the fields from the daemon and daemonParams
struct:

- EgressGatewayManager (unused - removed from daemon and daemonParams)
- HealthProvider (unused - removed from daemon and daemonParams)
- DeviceManager (keep in daemonParams)
- EndpointManager (set when initializing daemon struct)

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/k8s-watcher-cleanup-2 branch from 4b4c0dc to 31aa6ab Compare June 6, 2024 15:40
@mhofstetter
Copy link
Member Author

rebased to main to pick up some fixes for the failing Gateway API checks 🙏

@mhofstetter
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 6, 2024
Merged via the queue into cilium:main with commit b43dd5f Jun 6, 2024
@mhofstetter mhofstetter deleted the pr/mhofstetter/k8s-watcher-cleanup-2 branch June 6, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent Cilium agent related. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants