Skip to content

Cleanup leftovers from node statuses in CNP/CCNP #32877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

Cleanup leftovers from node statuses in CNP/CCNP #32877

merged 1 commit into from
Jun 6, 2024

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Jun 4, 2024 •
edited
Loading

Fixes: #29590
Fixes: #32903

Removed Cilium Operator options `cnp-status-cleanup-burst` and `cnp-status-cleanup-qps`

@marseel marseel added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/agent Cilium agent related. labels Jun 4, 2024
@marseel
Copy link
Contributor Author

marseel commented Jun 4, 2024

/test

@marseel marseel force-pushed the cleanup_node_statuses branch from 1927cdc to 221cc0e Compare June 4, 2024 11:20
@marseel
Cleanup leftovers from node statuses in CNP/CCNP
d31d5ab 
Fixes: cilium#29590

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the cleanup_node_statuses branch from 221cc0e to d31d5ab Compare June 4, 2024 11:22
@marseel
Copy link
Contributor Author

marseel commented Jun 4, 2024

/test

@marseel marseel requested a review from christarazi June 4, 2024 13:31
@marseel marseel marked this pull request as ready for review June 4, 2024 13:31
@marseel marseel requested review from a team as code owners June 4, 2024 13:31
@marseel marseel requested a review from nathanjsweet June 4, 2024 13:31
@marseel marseel mentioned this pull request Jun 4, 2024
Closed
christarazi
christarazi approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

nathanjsweet
nathanjsweet approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a single line added. Noice!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 6, 2024
Merged via the queue into cilium:main with commit 55bf8fa Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/agent Cilium agent related. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: TestControlPlane/CNPStatusNodesGC timed out Remove skip-cnp-status-startup-clean and CNP status
4 participants
@marseel @nathanjsweet @christarazi @julianwiedmann