Some minor but helpful ipcache performance improvements: #32876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
squeed
commented
Jun 4, 2024
christarazi
reviewed
Jun 4, 2024
gandro
approved these changes
Jun 5, 2024
It turns out that label injection panics if identity allocation fails. This code-path is not practically reachable, as we would need to run out of local identities. Still good to clean up, though. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
This is a private function that should never be called directly. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
If a large number of prefixes are queued for update, then we should not update all at the same time. This is because outgoing identities are only released at the end of doInjectLabels(), which means we could double the set of in-use identities while application is happening. The only exception is for the first run, in which case there is no point in dividing, as no identities will be released. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
If a particular upsert operation is a no-op, then there's no point in enqueuing a prefix update for it. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
d58ab61 to
354a295
Compare
|
/ci-runtime |
|
/ci-integration |
|
/test |
christarazi
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tightens up the queued-prefix side of the ipcache asynchronous layer:
(see individual commit messages for more detail)