Skip to content

dnsproxy: Pick up cilium/dns with ID retry logic #32870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2024
Merged

dnsproxy: Pick up cilium/dns with ID retry logic #32870

merged 1 commit into from
Jun 9, 2024

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Jun 4, 2024 •
edited
Loading

Update to cilium/dns with request ID retry logic to reduce the likelihood of failures like this:

level=error msg="Cannot forward proxied DNS lookup" error="duplicate request id 31372" subsys=fqdn/dnsproxy

Cilium dnsproxy now retries forwarded request id allocation before failing for a duplicate request id.

@jrajahalme jrajahalme added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. area/fqdn Affects the FQDN policies feature labels Jun 4, 2024
@jrajahalme jrajahalme requested a review from a team as a code owner June 4, 2024 09:38
@jrajahalme jrajahalme requested review from learnitall and marseel June 4, 2024 09:38
marseel
marseel approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

learnitall
learnitall approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jrajahalme
Copy link
Member Author

/test

@jrajahalme
dnsproxy: Pick up cilium/dns with ID retry logic
5835fba 
Update to cilium/dns with request ID retry logic to reduce the likelihood
of failures like this:

  level=error msg="Cannot forward proxied DNS lookup" error="duplicate request id 31372" subsys=fqdn/dnsproxy

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the cilium-dns-retry-id branch from 1ec1a6e to 5835fba Compare June 8, 2024 16:45
@jrajahalme
Copy link
Member Author

rebased in hopes the CI will behave better

@jrajahalme
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2024
@jrajahalme jrajahalme added this pull request to the merge queue Jun 9, 2024
Merged via the queue into cilium:main with commit 3bdfd9d Jun 9, 2024
@jrajahalme jrajahalme deleted the cilium-dns-retry-id branch June 9, 2024 15:57
@julianwiedmann julianwiedmann mentioned this pull request Jun 10, 2024
Closed
@bimmlerd bimmlerd added affects/v1.15 This issue affects v1.15 branch affects/v1.14 This issue affects v1.14 branch labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marseel marseel marseel approved these changes

+1 more reviewer

@learnitall learnitall learnitall approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
affects/v1.14 This issue affects v1.14 branch affects/v1.15 This issue affects v1.15 branch area/fqdn Affects the FQDN policies feature kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrajahalme @marseel @learnitall @bimmlerd