helm: Decouple sysctlfix from cgroup.autoMount #32866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4db52de to
9c6d794
Compare
ghost
approved these changes
Jun 4, 2024
|
/test |
youngnick
approved these changes
Jun 6, 2024
2bf4d11 to
e25fef1
Compare
|
/test |
squeed
reviewed
Jun 6, 2024
squeed
approved these changes
Jun 6, 2024
|
Cilium E2E Upgrade: #32689 |
0b92154 to
03a5853
Compare
|
/test |
|
Looks like Conformance Ingress is failing consistently for this PR. Let me investigate it. |
Currently, the sysctlfix is only enabled when cgroup.autoMount is enabled which is not a directly-related feature. This dependency is introduced because the host procfs mount is only enabled when cgroup.autoMount is enabled. Due to this limitation, we recently observed the issue that disabling cgroup.autoMount in the environment that runs systemd 245+ makes a connectivity loss between nodes in tunnel mode due to the rp_filter. To fix the above issue, introduce a new configuration knob to enable/disable sysctlfix individually. It is enabled by default. Fixes: cilium#20643 Co-authored-by: Nick Young <inocuo@gmail.com> Signed-off-by: Yutaro Hayakawa <yhayakawa3720@gmail.com>
03a5853 to
cc341cf
Compare
|
/test |
|
Looks like rebasing on the latest main fixed the issue. |
|
Conformance Ingress: #31857 |
|
Cilium E2E Upgrade: #32689 |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the sysctlfix is only enabled when cgroup.autoMount is enabled which is not a directly-related feature. This dependency is introduced because the host procfs mount is only enabled when cgroup.autoMount is enabled.
Due to this limitation, we recently observed the issue that disabling cgroup.autoMount in the environment that runs systemd 245+ makes a connectivity loss between nodes in tunnel mode due to the rp_filter.
To fix the above issue, introduce a new configuration knob to enable/disable sysctlfix individually. It is enabled by default.
Fixes: #20643