Prepare for release v1.16.0-pre.3 #32857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f169cea to
95136c8
Compare
|
/test |
christarazi
approved these changes
Jun 3, 2024
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
This reverts commit 4315545. Signed-off-by: André Martins <andre@cilium.io>
95136c8 to
83ec4e0
Compare
joestringer
reviewed
Jun 3, 2024
Comment on lines
-73
to
+123
| | v1.16.0-pre.0 | 1.29.2 | | ||
| +--------------------+----------------+ | ||
| | v1.16.0-pre.1 | 1.29.4 | | ||
| +--------------------+----------------+ | ||
| | v1.16.0-pre.2 | 1.29.5 | | ||
| | v1.15 | 1.28.2 | |
There was a problem hiding this comment.
This looks like check-crd-compat-table.sh was run with v1.15 as the argument, so it incorrectly included v1.13 versions and excluded v1.16 (which is this target version).
I've fixed it by running the main version of the script from the v1.16 preparation dir with check-crd-compat-table.sh v1.16 --update.
There was a problem hiding this comment.
(No I didn't fix it, this was merged before I could fix it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for release v1.16.0-pre.3
See the included CHANGELOG.md for a full list of changes.