Skip to content

gha: correctly trigger integration tests via ariane commands #32843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jun 3, 2024

The blamed commit backported the GHA-based integration tests to v1.13. However, it missed registering them into the Ariane configuration, which means that tests are not executed upon /test-backport-1.13, nor by means of the scheduled trigger. Let's fix it.

Fixes: 7531e09 ("introduce ARM github workflows")

The blamed commit backported the GHA-based integration tests to v1.13.
However, it missed registering them into the Ariane configuration, which
means that tests are not executed upon /test-backport-1.13, nor by
means of the scheduled trigger. Let's fix it.

Fixes: 7531e09 ("introduce ARM github workflows")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jun 3, 2024
@giorio94 giorio94 requested review from a team as code owners June 3, 2024 07:22
@giorio94 giorio94 requested review from aanm and nebril June 3, 2024 07:22
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 kind/backports This PR provides functionality previously merged into master. labels Jun 3, 2024
@giorio94
Copy link
Member Author

giorio94 commented Jun 3, 2024

/test-backport-1.13

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) Tests NodePort inside cluster (kube-proxy) 

Failure Output

FAIL: Request from testclient-hvgqb pod to service tftp://[fd04::12]:30391/hello failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/1235/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@giorio94
Copy link
Member Author

giorio94 commented Jun 3, 2024

k8s-1.25-kernel-4.19 failure looks like #21279, and cannot be related to this PR. Marking as ready to merge.

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 3, 2024
@aanm aanm merged commit 2c6c18d into v1.13 Jun 3, 2024
@aanm aanm deleted the pr/giorio94/v1.13/gha-integration-test-ariane branch June 3, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

3 participants