datapath: Add support for skipping direct routes on different L2 networks #32733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
966a654 to
135b59c
Compare
|
Thanks for the quick review @lambdanis, actioned comments. |
06aa612 to
fa21f25
Compare
|
/test |
asauber
requested changes
May 31, 2024
|
Let's pause this PR just for a bit while we discuss this point: #31124 (comment) Overall, the PR looks generally harmless and I'm not opposed, but I'd like to square up across contributors on whether this is the right answer, or if this should become a BGP responsibility. |
ldelossa
approved these changes
Jun 4, 2024
|
@jleeh please run 'make -C Documentation update-cmdref' and push changes back up. That is why the |
|
/test |
1 similar comment
|
/test |
|
@jleeh the PR needs a rebase as the CI is failing due to some flakes. |
44cf6cd to
5aa1fb8
Compare
|
Rebased @aanm |
…orks Previously, when a cluster ran with native-networking and had multiple zones, it wasn't possible to enable auto direct routes. This caused a bottleneck for same-zone traffic as it always had to be routed through the gw. With this new flag, any direct routes for nodes on different L2 networks will be skipped. Cilium will add routes for nodes on the same L2 and not exit. Fixes: cilium#31124 Signed-off-by: Jonny <jonny@linkpool.io>
|
/test |
xmulligan
approved these changes
Jun 17, 2024
ShivamJha2436
approved these changes
Jul 22, 2024
Closed
3 tasks
baurmatt
added a commit
to syseleven/cilium
that referenced
this pull request
Oct 14, 2024
Seems like the config option has been renamed in the inital PR while it was reviewed but this instance has been missed. See cilium#32733
baurmatt
added a commit
to syseleven/cilium
that referenced
this pull request
Oct 14, 2024
Seems like the config option has been renamed in the inital PR while it was reviewed but this instance has been missed. See cilium#32733 Signed-off-by: Matthias Baur <m.baur@syseleven.de>
baurmatt
added a commit
to syseleven/cilium
that referenced
this pull request
Oct 22, 2024
Seems like the config option has been renamed in the inital PR while it was reviewed but this instance has been missed. See cilium#32733 Signed-off-by: Matthias Baur <m.baur@syseleven.de>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Seems like the config option has been renamed in the inital PR while it was reviewed but this instance has been missed. See #32733 Signed-off-by: Matthias Baur <m.baur@syseleven.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Previously, when a cluster ran with native-networking and had multiple zones, it wasn't possible to enable auto direct routes. This caused a bottleneck for same-zone traffic as it always had to be routed through the gw.
With this new flag, any direct routes for nodes on different L2 networks will be skipped. Cilium will add routes for nodes on the same L2 and not exit.
Fixes: #31124
Regarding tests, I couldn't get the
node_linux_test.gofile to run locally when in privileged mode. I'm not sure how applicable it is to add a test specifically for this with how the current tests are written and with the new flag.I've ran this Cilium build on our staging cluster and works as intended.