v1.15: Revert the change to the golang image version of hubble-relay #32732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-backport-1.15 |
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
a08d128 to
5c56009
Compare
lmb
reviewed
May 28, 2024
| @@ -446,7 +446,7 @@ jobs: | |||
| --sysdump-output-filename "cilium-sysdump-${{ matrix.name }}-<ts>" \ | |||
| --junit-file "cilium-junits/${{ env.job_name }} (${{ join(matrix.*, ', ') }}).xml" \ | |||
| --junit-property github_job_step="Run tests upgrade 2 (${{ join(matrix.*, ', ') }})" \ | |||
| \$EXTRA | |||
| $EXTRA | |||
There was a problem hiding this comment.
So this gets rid of unnecessary escaping?
There was a problem hiding this comment.
Oh, yeah. I was thinking it is just a cosmetic thing, but actually it was mistakenly escaped.
In the upstream, it is fixed:
lmb
approved these changes
May 28, 2024
nebril
approved these changes
May 28, 2024
aanm
approved these changes
May 28, 2024
|
/test-backport-1.15 |
joestringer
approved these changes
May 29, 2024
michi-covalent
added a commit
to cilium/release
that referenced
this pull request
Jun 18, 2024
In my env, the command `tail -n+4 CHANGELOG.md | sed '/^## v.*$/q'`
includes the version header of the previous command. Grep it out.
% tail -n+4 CHANGELOG.md | sed '/^## v.*$/q'
Summary of Changes
------------------
**Minor Changes:**
...
* Revert golang image version of hubble-relay (cilium/cilium#32732, @YutaroHayakawa)
## v1.15.5
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
aanm
pushed a commit
to cilium/release
that referenced
this pull request
Jun 18, 2024
In my env, the command `tail -n+4 CHANGELOG.md | sed '/^## v.*$/q'`
includes the version header of the previous command. Grep it out.
% tail -n+4 CHANGELOG.md | sed '/^## v.*$/q'
Summary of Changes
------------------
**Minor Changes:**
...
* Revert golang image version of hubble-relay (cilium/cilium#32732, @YutaroHayakawa)
## v1.15.5
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly bumped up the golang image version in hubble-relay Dockerfile in the v1.15 backport. Revert it. Also, let me piggy-back the very small
cosmetic changebugfix for GHA.Fixes: #32691