Skip to content

LRP: Add explicit dependency to k8s ServiceCache #32796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

LRP: Add explicit dependency to k8s ServiceCache #32796

merged 1 commit into from
Jun 4, 2024

Conversation

mhofstetter
Copy link
Member

Currently, the Agent daemon setup registers the k8s ServiceCache with the LRP Manager via the method RegisterSvcCache.

In the meantime, the k8s ServiceCache is provided by its own Hive Cell which makes it possible to have an explicit dependency from the LRP Manager to the ServiceCache.

Therefore, this commit adds the k8s ServiceCache as direct dependency to the LRP Manager and removes the method RegisterSvcCache.

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/lrp Impacts Local Redirect Policy. area/modularization Relates to code modularization and maintenance. labels May 30, 2024
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review May 30, 2024 13:48
@mhofstetter mhofstetter requested review from a team as code owners May 30, 2024 13:49
@mhofstetter mhofstetter requested review from aditighag and ldelossa May 30, 2024 13:49
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/lrp-svccache-dep branch from d5cb61b to b13fdce Compare May 31, 2024 15:30
@mhofstetter
Copy link
Member Author

rebased to main to resolve conflicts

@mhofstetter
Copy link
Member Author

/test

aditighag
aditighag approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
nit: Can you revert the white space changes if they weren't added by a standard golang style check linter?

@mhofstetter
LRP: Add explicit dependency to k8s ServiceCache
e105ffb 
Currently, the Agent daemon setup registers the k8s `ServiceCache` with
the LRP Manager via the method `RegisterSvcCache`.

In the meantime, the k8s `ServiceCache` is provided by its own Hive Cell
which makes it possible to have an explicit dependency from the LRP
Manager to the `ServiceCache`.

Therefore, this commit adds the k8s `ServiceCache` as direct dependency to
the LRP Manager and removes the method `RegisterSvcCache`.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/lrp-svccache-dep branch from b13fdce to e105ffb Compare June 3, 2024 07:14
@joamaki joamaki self-requested a review June 3, 2024 16:59
@mhofstetter mhofstetter removed the request for review from ldelossa June 3, 2024 17:01
@mhofstetter
Copy link
Member Author

/test

ldelossa
ldelossa approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 3, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 4, 2024
Merged via the queue into cilium:main with commit 541bd8c Jun 4, 2024
@mhofstetter mhofstetter deleted the pr/mhofstetter/lrp-svccache-dep branch June 4, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag approved these changes

@joamaki joamaki joamaki approved these changes

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/lrp Impacts Local Redirect Policy. area/modularization Relates to code modularization and maintenance. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhofstetter @joamaki @ldelossa @aditighag @julianwiedmann