-
Notifications
You must be signed in to change notification settings - Fork 3.4k
v1.14 Backports 2024-05-30 #32787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v1.14 Backports 2024-05-30 #32787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 7afb7c6 ] Make sure to test all the three supported certificate generation methods (i.e., helm, cronJob and certmanager) to prevent possible regressions affecting only one of them. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit 6a014ff ] This aids in troubleshooting, as the list of ports is not visible anywhere else in the sysdump. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Jussi Maki <jussi@isovalent.com>
[ upstream commit 76ecb4b ] This fixes a bug where the port reservation of ports which can conflict with transparent DNS proxy where only reserved if IPv6 was enabled. The call to `reserveLocalIPPorts` was accidentally added in the "IPv6-only" branch. This commit fixes that by unconditionally reserving local ports. Fixes: 11fe7cc ("cilium-cni: Reserve ports that can conflict with transparent DNS proxy") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 4cda262 ] In the latest state, lint-build-commits takes over 90min. While it is not desirable to take many time, bump it to 180min as a workaround. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com> Signed-off-by: Jussi Maki <jussi@isovalent.com>
/test-backport-1.14 |
giorio94
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My commit look good, thanks!
aanm
approved these changes
May 30, 2024
YutaroHayakawa
approved these changes
May 30, 2024
joestringer
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.14
This PR represents a backport for Cilium 1.14.x of a PR that was merged to main.
kind/backports
This PR provides functionality previously merged into master.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed minor conflict in #32725 due to filename renames. Diff looks the same.
With #32654 there were some lines in the diff that did not exist in v1.14 version of conformance-clustermesh.yaml,
so fixed up manually. Please double-check that this patch makes sense for v1.14.
Once this PR is merged, a GitHub action will update the labels of these PRs: