images: bump cni plugins to v1.5.0 #32629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of running ``` images/scripts/update-cni-version.sh 1.5.0 ``` Signed-off-by: Anton Ippolitov <anton.ippolitov@datadoghq.com>
|
I think I also need to update the actual images like it was done here: #31347 Edit: nvm, found the docs here https://docs.cilium.io/en/latest/contributing/development/images/#update-cilium-builder-and-cilium-runtime-images |
|
@antonipp it looks like the second commit |
291b77d to
10cf348
Compare
|
Yes, sorry, just fixed it! |
|
/test |
tklauser
approved these changes
May 21, 2024
|
@antonipp it looks like there's still something off with the image hashes and |
Signed-off-by: Anton Ippolitov <anton.ippolitov@datadoghq.com>
auto-merge was automatically disabled
May 22, 2024 09:00
Head branch was pushed to by a user without write access
10cf348 to
48c5563
Compare
|
Ok, I re-ran and pushed the changes. (I believe that's what the docs instruct to do when the "PR was opened from an external fork") |
bimmlerd
approved these changes
May 22, 2024
|
/test |
tklauser
approved these changes
May 22, 2024
15 tasks
12 tasks
10 tasks
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cilium-runtimeimage can no longer be built onmainbecause the CNI plugin binaries for v1.4.1 were updated in-place: containernetworking/plugins#1038The SHAs on
mainare:cilium/images/runtime/cni-version.sh
Lines 4 to 5 in db5fcdc
and the new SHAs upstream are now:
I suggest that we no longer use 1.4.1 and we move towards 1.5.0 which was released properly yesterday. The changelog is very minimal so the bump should be relatively safe: https://github.com/containernetworking/plugins/releases/tag/v1.5.0