Introduce clustermesh source to differentiate data retrieved from remote clusters #32688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new clustermesh source to identify data that is retrieved from and refers to remote clusters. This enables to better identify the source of the given piece of information, rather than marking it as originating from the kvstore. The clustermesh source is additionally characterized by lower priority, to prevent conflicting information retrieved from a remote cluster from taking precedence over local cluster data (regardless of CRD/kvstore mode). Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
So that we can configure the kvstore source when data is retrieved from the main kvstore instance, and clustermesh if retrieved from remote clusters. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
So that we can configure the kvstore source when data is retrieved from the main kvstore instance, and clustermesh if retrieved from remote clusters. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
This was referenced May 23, 2024
Closed
YutaroHayakawa
approved these changes
May 28, 2024
doniacld
approved these changes
May 28, 2024
Yeah, I know that there's no full integration test at the moment for that. The reason being that the setting is pretty trivial (just configuring a value), but testing it with the current setup is quite complex (I'm working on a few followup changes that would simplify that). Differently, the PR already tests the correct propagation of the source in the ipcache watcher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new clustermesh source to identify data that is retrieved from and refers to remote clusters. This enables to better identify the source of the given piece of information, rather than marking it as originating from the kvstore. The clustermesh source is additionally characterized by lower priority, to prevent conflicting information retrieved from a remote cluster from taking precedence over local cluster data (regardless of CRD/kvstore mode).
Please review commit by commit, and refer to the individual descriptions for additional details.