Skip to content

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented May 21, 2024

Make sure to test all the three supported certificate generation methods (i.e., helm, cronJob and cert-manager) to prevent possible regressions affecting only one of them.

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels May 21, 2024
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-clustermesh-certs branch from 98760ee to 98766f8 Compare May 21, 2024 16:37
Make sure to test all the three supported certificate generation methods
(i.e., helm, cronJob and certmanager) to prevent possible regressions
affecting only one of them.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-clustermesh-certs branch from 98766f8 to 8b48f7b Compare May 21, 2024 16:52
@giorio94
Copy link
Member Author

/ci-clustermesh

@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-clustermesh-certs branch from 8b48f7b to 524ede0 Compare May 22, 2024 07:03
@giorio94
Copy link
Member Author

/test

@giorio94 giorio94 marked this pull request as ready for review May 22, 2024 07:03
@giorio94 giorio94 requested review from a team as code owners May 22, 2024 07:03
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@giorio94
Copy link
Member Author

@YutaroHayakawa Gentle ping 🙏

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 28, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 7afb7c6 May 28, 2024
@julianwiedmann julianwiedmann deleted the pr/giorio94/main/gha-clustermesh-certs branch May 28, 2024 06:01
@joamaki joamaki mentioned this pull request May 30, 2024
3 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels May 30, 2024
@joamaki joamaki mentioned this pull request May 30, 2024
6 tasks
@joamaki joamaki added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label May 30, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Backport done to v1.14
Status: Backport done to v1.15
Status: Released
Status: Released
Development

Successfully merging this pull request may close these issues.

5 participants