Skip to content

ingress: Support headless service #32644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

ingress: Support headless service #32644

merged 1 commit into from
Jun 4, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 21, 2024 •
edited
Loading

Currently, we don't inject headless endpoints into envoy XDS, hence the response is coming with error no healthy upstream. This commit is to explicitly handle headless service in CEC controller.

Fixes: #23182

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2024
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2024
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from 751f62c to 6b9ae28 Compare May 21, 2024 14:43
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from 6b9ae28 to 8cb5b3e Compare May 22, 2024 11:14
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from 8cb5b3e to 0cc9459 Compare May 22, 2024 11:25
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from 0cc9459 to c0c1ff4 Compare May 22, 2024 11:27
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from c0c1ff4 to 90e8b23 Compare May 22, 2024 12:57
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from 90e8b23 to c744f40 Compare May 22, 2024 12:59
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from c744f40 to 4940473 Compare May 22, 2024 14:08
@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from 4940473 to a16a273 Compare May 22, 2024 14:55
@sayboras
Copy link
Member Author

/ci-ingress

@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from a16a273 to a83a327 Compare May 23, 2024 06:03
@sayboras
Copy link
Member Author

/test

@sayboras sayboras mentioned this pull request May 23, 2024
Closed
2 tasks
@sayboras sayboras marked this pull request as ready for review May 23, 2024 11:07
@sayboras sayboras requested review from a team as code owners May 23, 2024 11:07
@sayboras sayboras requested a review from tommyp1ckles May 23, 2024 11:07
@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from a83a327 to 1487da3 Compare May 27, 2024 13:26
viktor-kurchenko
viktor-kurchenko approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrajahalme
Copy link
Member

/test

@sayboras sayboras added the release-blocker/1.16 This issue will prevent the release of the next version of Cilium. label Jun 4, 2024
@sayboras
ingress: Support headless service
31053ee 
Currently, we don't inject headless endpoints into envoy XDS, hence the
response is coming with error `no healthy upstream`. This commit is to
explicitly handle headless service in CEC controller.

One point worth noting is that k8s.Endpoint watcher is used as it's a
wrapper for both k8s Endpoint and EndpointSlice.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/ingress-headless-again branch from 1487da3 to 31053ee Compare June 4, 2024 04:54
@sayboras
Copy link
Member Author

sayboras commented Jun 4, 2024

/test

@aanm aanm added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit cce4080 Jun 4, 2024
@aanm aanm deleted the pr/tammach/ingress-headless-again branch June 4, 2024 07:55
@marseel marseel mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
release-blocker/1.16 This issue will prevent the release of the next version of Cilium. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
Release blockers
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingress: No healthy upstream for headless service
4 participants
@sayboras @jrajahalme @aanm @viktor-kurchenko