-
Notifications
You must be signed in to change notification settings - Fork 3.4k
v1.13 Backports 2024-05-13 #32504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v1.13 Backports 2024-05-13 #32504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 77cafec ] This commit adds a new job to the beginning of workflows that have a workflow_dispatch trigger whose inputs provide important context to the run. The job echos the inputs so they can be viewed in the logs by users. A majority of the workflows in the cilium repository have a workflow_dispatch trigger, which is used by users and Ariane to run workflows as needed. These workflows take a variety of inputs that may not always be made available in the logs, as they may not be used in a place that warrants their value being outputted. This obfuscation can make debugging these workflows difficult at times, as these inputs provide important context to the origin of the workflow's trigger. For instance, the `PR-number` input is used to determine the concurrency group for a workflow run. It is ignored everywhere else. The value of the concurrency group is not available via GitHub's UI or API, therefore this input obfuscated. However, the `PR-number` input provides valuable metadata, being used to describe the branch or PR that a workflow was triggered for. Fixes: #31207 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
/test-backport-1.13 |
michi-covalent
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra power!
/test-1.21-4.19 |
test-1.22-4.19 |
viktor-kurchenko
approved these changes
May 13, 2024
learnitall
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/test-1.22-4.19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/backports
This PR provides functionality previously merged into master.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: