Skip to content

Conversation

jibi
Copy link
Member

@jibi jibi commented May 13, 2024

Once this PR is merged, a GitHub action will update the labels of these PRs:

 31424 32402

learnitall and others added 2 commits May 13, 2024 11:31
[ upstream commit 77cafec ]

This commit adds a new job to the beginning of workflows that have a
workflow_dispatch trigger whose inputs provide important context to the
run. The job echos the inputs so they can be viewed in the logs by users.

A majority of the workflows in the cilium repository have a
workflow_dispatch trigger, which is used by users and Ariane to run
workflows as needed. These workflows take a variety of inputs that may
not always be made available in the logs, as they may not be used in a
place that warrants their value being outputted. This obfuscation can make
debugging these workflows difficult at times, as these inputs provide
important context to the origin of the workflow's trigger.

For instance, the `PR-number` input is used to determine the concurrency
group for a workflow run. It is ignored everywhere else. The value of
the concurrency group is not available via GitHub's UI or API, therefore
this input obfuscated. However, the `PR-number` input provides valuable
metadata, being used to describe the branch or PR that a workflow was
triggered for.

Fixes: #31207

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 4bc5c06 ]

Similar to #30496, use GH_RUNNER_EXTRA_POWER for the CI image workflow.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi added kind/backports This PR provides functionality previously merged into master. backport/1.13 labels May 13, 2024
@jibi jibi requested review from learnitall and michi-covalent May 13, 2024 09:32
@jibi
Copy link
Member Author

jibi commented May 13, 2024

/test-backport-1.13

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra power!

@jibi
Copy link
Member Author

jibi commented May 13, 2024

/test-1.21-4.19

@jibi
Copy link
Member Author

jibi commented May 13, 2024

test-1.22-4.19

@jibi jibi marked this pull request as ready for review May 13, 2024 15:35
@jibi jibi requested review from a team as code owners May 13, 2024 15:35
@jibi jibi requested a review from viktor-kurchenko May 13, 2024 15:35
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jibi
Copy link
Member Author

jibi commented May 14, 2024

/test-1.22-4.19

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 14, 2024
@jibi jibi merged commit 78e5218 into v1.13 May 14, 2024
@jibi jibi deleted the pr/v1.13-backport-2024-05-13-11-30 branch May 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

4 participants