eks: Don't use spot instances #32553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's causing unnecessary flakes. Money is not a concern so let's not bother using spot instances. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
learnitall
approved these changes
May 15, 2024
Similar to EKS, money is not a concern here so let's not bother with preemptible instances. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
|
/test |
aanm
approved these changes
May 16, 2024
8 tasks
|
@michi-covalent Should we backport this to stable branches as well? |
|
oh yeah might as well. let me set backport labels 🚀 🙏 |
15 tasks
12 tasks
10 tasks
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's causing unnecessary flakes. Money is not a concern so let's not bother using spot instances.
edit: now there are 2 commits: