Skip to content

Conversation

squeed
Copy link
Contributor

@squeed squeed commented May 15, 2024

We had the value, but forgot to plumb it in.

Fixes: #32497

Fixes accidentally ignoring the preflight.nodeSelector Helm value.

We had the value, but forgot to plumb it in.

Fixes: cilium#32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 15, 2024
@squeed squeed requested review from a team as code owners May 15, 2024 11:34
@squeed squeed requested review from joamaki and gandro May 15, 2024 11:34
@squeed
Copy link
Contributor Author

squeed commented May 15, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2024
@squeed squeed added this pull request to the merge queue May 16, 2024
Merged via the queue into cilium:main with commit a1e5295 May 16, 2024
@squeed squeed deleted the fix-preflight-nodeselector branch May 16, 2024 10:18
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 23, 2024
15 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels May 23, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 24, 2024
12 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels May 24, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 24, 2024
10 tasks
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels May 25, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
Status: Released
Status: Released
Status: Released
Development

Successfully merging this pull request may close these issues.

Helm Values: preflight.nodeSelector Does Not Render Correctly
4 participants