Skip to content

envoy: Update to use original source address also for external destinations #32331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2024
Merged

envoy: Update to use original source address also for external destinations #32331

merged 2 commits into from
May 19, 2024

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented May 3, 2024 •
edited
Loading

Update cilium-envoy to use original source address also for external destinations.

Change to support original source addressing regardless of the datapath mode.

Related cilium-envoy change: cilium/proxy#742

@jrajahalme jrajahalme requested review from a team as code owners May 3, 2024 05:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 3, 2024
@jrajahalme jrajahalme added the dont-merge/preview-only Only for preview or testing, don't merge it. label May 3, 2024
@jrajahalme
Copy link
Member Author

/test

@squeed
Copy link
Contributor

squeed commented May 3, 2024

Can you link to the corresponding cilium-envoy changes? And what's the procedure for rolling out a change to both repositories -- do we tag a new c-e version first, or use a -dev image until release day, then tag both at the same time?

@jrajahalme
Copy link
Member Author

Can you link to the corresponding cilium-envoy changes? And what's the procedure for rolling out a change to both repositories -- do we tag a new c-e version first, or use a -dev image until release day, then tag both at the same time?

Added link to the PR into the description.

Currently we do not tag cilium-envoy releases. Release builds are made from each merge to main and release branches, so updating cilium agent repo to those can be merged without any further process.

-dev images are built for cilium/proxy PRs, cilium/cilium PRs referring to those should never be merged. Once we figure PR is good to merge, we can then use the release builds and merge.

@jrajahalme jrajahalme force-pushed the envoy-world-use-original-source branch from 3b2ce97 to ad10530 Compare May 8, 2024 16:41
@jrajahalme jrajahalme added the release-note/misc This PR makes changes that have no direct user impact. label May 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 8, 2024
@jrajahalme jrajahalme added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. and removed dont-merge/preview-only Only for preview or testing, don't merge it. labels May 8, 2024
@jrajahalme jrajahalme force-pushed the envoy-world-use-original-source branch from ad10530 to 52b3306 Compare May 10, 2024 05:13
@jrajahalme
Copy link
Member Author

Rebased to resolve context conflict in images/cilium/Dockerfile

@jrajahalme
Copy link
Member Author

/test

@sayboras sayboras added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 14, 2024
@jrajahalme jrajahalme force-pushed the envoy-world-use-original-source branch from 52b3306 to b5ad4c0 Compare May 16, 2024 12:27
@jrajahalme
Copy link
Member Author

Rebased for trivial Dockerfile conflict

@jrajahalme
Copy link
Member Author

/test

@jrajahalme jrajahalme removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 16, 2024
jrajahalme added 2 commits May 19, 2024 10:37
@jrajahalme
envoy: Update to use original source address also for external destin…
79f02d6 
…ations

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme
datapath: Support original source address regardless of datapath mode
cfc0daf 
Support original source address regardless of the datapath mode. This
allows Envoy to use original source address also in the tunnel datapath
modes.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the envoy-world-use-original-source branch from b5ad4c0 to cfc0daf Compare May 19, 2024 08:38
@jrajahalme
Copy link
Member Author

rebased due to images no longer being available for the last test

@jrajahalme
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 19, 2024
@jrajahalme jrajahalme added this pull request to the merge queue May 19, 2024
Merged via the queue into cilium:main with commit 322de7a May 19, 2024
@jrajahalme jrajahalme deleted the envoy-world-use-original-source branch May 19, 2024 16:04
This was referenced May 23, 2024
Merged
Closed
@jschwinger233 jschwinger233 mentioned this pull request Jun 4, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@borkmann borkmann borkmann approved these changes

@sayboras sayboras sayboras approved these changes

@youngnick youngnick youngnick approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jrajahalme @squeed @borkmann @sayboras @youngnick @julianwiedmann