Skip to content

egressgw: remove gwc.ifaceName #32321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2024
Merged

egressgw: remove gwc.ifaceName #32321

merged 2 commits into from
May 3, 2024

Conversation

julianwiedmann
Copy link
Member

Remove an unused field in the EGW policy parsing code. While at it also move the netdevice-related helpers in their own package.

@julianwiedmann
egressgw: migrate net.go into its own package
c7ec1f0 
These have the potential to be reused by other code, don't bury them in
the egressgw package.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
egressgw: remove gwc.ifaceName
a8fe239 
This isn't actually needed, we only care about the egressIP.

Update the function name accordingly.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. feature/egress-gateway Impacts the egress IP gateway feature. labels May 2, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann requested a review from jibi May 2, 2024 17:04
@julianwiedmann julianwiedmann marked this pull request as ready for review May 2, 2024 17:04
@julianwiedmann julianwiedmann requested review from a team as code owners May 2, 2024 17:04
@julianwiedmann julianwiedmann enabled auto-merge May 3, 2024 04:40
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 3, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 3, 2024
Merged via the queue into cilium:main with commit e122452 May 3, 2024
@julianwiedmann julianwiedmann deleted the 1.16-egressgw-iface branch May 3, 2024 15:41
@julianwiedmann
Copy link
Member Author

Marking for backport to help with conflicts in #32679.

@joamaki joamaki mentioned this pull request May 30, 2024
Merged
6 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/egress-gateway Impacts the egress IP gateway feature. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianwiedmann @jibi @joamaki