Skip to content

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented May 2, 2024

The cluster name is present in the set of labels associated to a Cilium endpoint. Adding the cluster name to a flow's source and destination endpoints will allow API clients such as Hubble UI to show if a flow is internal cluster traffic or going/coming from a different cluster (for instance, in a cluster mesh context).

hubble: add the cluster name to a flow's source and destination endpoints

@rolinh rolinh added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble labels May 2, 2024
@rolinh rolinh requested review from a team as code owners May 2, 2024 13:30
@rolinh rolinh requested a review from kaworu May 2, 2024 13:30
@sayboras
Copy link
Member

sayboras commented May 2, 2024

/test

Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch LGTM besides Tam's point about the label not being set for all endpoints.

@rolinh rolinh requested review from kaworu and sayboras May 2, 2024 14:51
@rolinh rolinh force-pushed the pr/rolinh/endpoint-cluster-name branch from aaa7285 to fbc7225 Compare May 3, 2024 08:17
@kaworu kaworu added the dont-merge/blocked Another PR must be merged before this one. label May 3, 2024
@kaworu
Copy link
Member

kaworu commented May 3, 2024

Added the blocked label to wait on #32130 and rebase on top.

rolinh added 2 commits May 8, 2024 12:26
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
The cluster name is present in the set of labels associated to a Cilium
endpoint. Adding the cluster name to a flow's source and destination
endpoints will allow API clients such as Hubble UI to show if a flow is
internal cluster traffic or going/coming from a different cluster (for
instance, in a cluster mesh context).

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Suggested-by: Tam Mach <tam.mach@cilium.io>
@rolinh rolinh force-pushed the pr/rolinh/endpoint-cluster-name branch from fbc7225 to 5e2d0ee Compare May 8, 2024 10:27
@rolinh
Copy link
Member Author

rolinh commented May 8, 2024

Added the blocked label to wait on #32130 and rebase on top.

#32130 is now merged, removing the blocking label.

@rolinh rolinh removed the dont-merge/blocked Another PR must be merged before this one. label May 8, 2024
@rolinh
Copy link
Member Author

rolinh commented May 8, 2024

/test

@rolinh rolinh enabled auto-merge May 8, 2024 16:54
@rolinh rolinh added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 163c874 May 9, 2024
@rolinh rolinh deleted the pr/rolinh/endpoint-cluster-name branch May 9, 2024 07:24
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants