-
Notifications
You must be signed in to change notification settings - Fork 3.4k
hubble: add the cluster name to a flow's source and destination endpoints #32313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
reviewed
May 2, 2024
/test |
kaworu
reviewed
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch LGTM besides Tam's point about the label not being set for all endpoints.
sayboras
approved these changes
May 2, 2024
kaworu
approved these changes
May 2, 2024
aaa7285
to
fbc7225
Compare
Added the blocked label to wait on #32130 and rebase on top. |
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
The cluster name is present in the set of labels associated to a Cilium endpoint. Adding the cluster name to a flow's source and destination endpoints will allow API clients such as Hubble UI to show if a flow is internal cluster traffic or going/coming from a different cluster (for instance, in a cluster mesh context). Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net> Suggested-by: Tam Mach <tam.mach@cilium.io>
fbc7225
to
5e2d0ee
Compare
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster name is present in the set of labels associated to a Cilium endpoint. Adding the cluster name to a flow's source and destination endpoints will allow API clients such as Hubble UI to show if a flow is internal cluster traffic or going/coming from a different cluster (for instance, in a cluster mesh context).