Skip to content

Conversation

marseel
Copy link
Contributor

@marseel marseel commented May 2, 2024

Whenever EKS stopped supporting a particular version of EKS, we had to
manually remove it from all stable branches. Now instead of that, we
will dynamically check if it's supported and only then run the test.

This implementation is not great as supported versions are hard-coded in
eksctl until EKS fixes it: aws/containers-roadmap#982 (comment)
Because of that, we always fetch newest eksctl version.

Followup on #32302

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 2, 2024
@marseel marseel added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels May 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 2, 2024
@marseel marseel added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. needs-backport/1.13 labels May 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 2, 2024
@marseel marseel added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. affects/v1.12 This issue affects v1.12 branch labels May 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 2, 2024
@marseel
Copy link
Contributor Author

marseel commented May 2, 2024

/test

@marseel
Copy link
Contributor Author

marseel commented May 2, 2024

/ci-awscni
/ci-eks

@marseel
Copy link
Contributor Author

marseel commented May 2, 2024

/test

@marseel
Copy link
Contributor Author

marseel commented May 2, 2024

Example run where I added 1.22: https://github.com/cilium/cilium/actions/runs/8923095382/job/24507488689

Removing version 1.22 as it's not supported
Version 1.26 is supported
Version 1.27 is supported
Version 1.28 is supported
Version 1.[29](https://github.com/cilium/cilium/actions/runs/8923095382/job/24507488689#step:7:30) is supported
Filtered matrix:
{
  "include": [
    {
      "version": "1.26",
      "region": "us-west-1"
    },
    {
      "version": "1.27",
      "region": "us-east-2",
      "ipsec": true
    },
    {
      "version": "1.28",
      "region": "ca-central-1",
      "ipsec": true
    },
    {
      "version": "1.29",
      "region": "us-east-1",
      "ipsec": true,
      "default": true
    }
  ]
}

@marseel
Copy link
Contributor Author

marseel commented May 2, 2024

/test

@marseel marseel marked this pull request as ready for review May 2, 2024 12:25
@marseel marseel requested review from a team as code owners May 2, 2024 12:25
@marseel marseel requested review from aanm and tklauser May 2, 2024 12:25
@marseel
Copy link
Contributor Author

marseel commented May 29, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot requested a review from aanm May 29, 2024 09:05
@aanm aanm enabled auto-merge May 29, 2024 18:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 29, 2024
@joestringer joestringer removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 30, 2024
@joestringer
Copy link
Member

Auto-merge is enabled. The discussion thread above must be resolved prior to merging.

@aanm aanm added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 7209275 May 31, 2024
@aanm aanm deleted the fix_ci3 branch May 31, 2024 10:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 31, 2024
@viktor-kurchenko viktor-kurchenko mentioned this pull request Jun 4, 2024
3 tasks
@viktor-kurchenko viktor-kurchenko mentioned this pull request Jun 4, 2024
3 tasks
@viktor-kurchenko viktor-kurchenko added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Jun 4, 2024
@viktor-kurchenko viktor-kurchenko mentioned this pull request Jun 4, 2024
5 tasks
@viktor-kurchenko viktor-kurchenko added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Jun 4, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.13 labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v1.12 This issue affects v1.12 branch area/CI Continuous Integration testing issue or flake backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Backport done to v1.14
Status: Backport done to v1.15
Status: Released
Status: Released
Status: Released
Development

Successfully merging this pull request may close these issues.

6 participants