Skip to content

proxy: Re-enable proxy rule installation in native-routing mode for CEC #32367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 10, 2024
Merged

proxy: Re-enable proxy rule installation in native-routing mode for CEC #32367

merged 4 commits into from
May 10, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 6, 2024 •
edited by julianwiedmann
Loading

This commit is to re-enable proxy rule installation in native-routing mode if
cilium envoy config or ipsec is enabled. The reason is to handle the
reply packet of hair-pinning traffic in Ingress L7 proxy (i.e. backend
is in the same node).

Relates: 0ebe516
Relates: #29530, #29864

Signed-off-by: Tam Mach tam.mach@cilium.io

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 6, 2024
@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.15 labels May 6, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 6, 2024
@sayboras sayboras force-pushed the pr/tammach/ingress-samenode-direct branch from 8c07609 to 53046f3 Compare May 6, 2024 06:48
@sayboras
Copy link
Member Author

sayboras commented May 6, 2024

/test

@sayboras sayboras force-pushed the pr/tammach/ingress-samenode-direct branch 2 times, most recently from 67788d1 to d787685 Compare May 6, 2024 07:43
@sayboras
Copy link
Member Author

sayboras commented May 6, 2024

/test

1 similar comment
@sayboras
Copy link
Member Author

sayboras commented May 6, 2024

/test

@sayboras sayboras mentioned this pull request May 6, 2024
Merged
@sayboras sayboras force-pushed the pr/tammach/ingress-samenode-direct branch from d787685 to cf0405d Compare May 6, 2024 10:39
@sayboras sayboras added the dont-merge/preview-only Only for preview or testing, don't merge it. label May 6, 2024
@sayboras
Copy link
Member Author

sayboras commented May 6, 2024

/test

@sayboras sayboras force-pushed the pr/tammach/ingress-samenode-direct branch 2 times, most recently from 23da70c to 98ec4fb Compare May 6, 2024 14:59
@sayboras
Copy link
Member Author

sayboras commented May 6, 2024

/test

@sayboras sayboras removed the dont-merge/preview-only Only for preview or testing, don't merge it. label May 6, 2024
@sayboras sayboras marked this pull request as ready for review May 6, 2024 16:02
@sayboras sayboras requested review from a team as code owners May 6, 2024 16:02
@sayboras sayboras added backport/author The backport will be carried out by the author of the PR. and removed backport/author The backport will be carried out by the author of the PR. labels May 11, 2024
@sayboras sayboras mentioned this pull request May 11, 2024
Merged
1 task
@sayboras sayboras added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport/author The backport will be carried out by the author of the PR. backport-pending/1.13 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.15 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels May 11, 2024
@sayboras sayboras mentioned this pull request May 11, 2024
Merged
1 task
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels May 11, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 12, 2024
@sayboras sayboras mentioned this pull request May 13, 2024
Closed
2 tasks
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels May 15, 2024
@jschwinger233 jschwinger233 mentioned this pull request May 21, 2024
Merged
@jschwinger233 jschwinger233 mentioned this pull request May 30, 2024
Merged
This was referenced Jun 8, 2024
Merged
Merged
This was referenced Jun 20, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@giorio94 giorio94 giorio94 approved these changes

@derailed derailed derailed approved these changes

@christarazi christarazi christarazi approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.14.12
Status: Needs backport from main
1.15.6
Status: Needs backport from main
cilium v1.14.12
Status: Released
cilium v1.15.6
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sayboras @youngnick @derailed @christarazi @tommyp1ckles @julianwiedmann @michi-covalent @giorio94 @viktor-kurchenko