Decouple CiliumEndpointSlice controller from operator Clientset #32353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25f65e7 to
51db531
Compare
|
/test |
|
found a real CI failure, putting back into draft until I apply a fix |
51db531 to
4c6e4d4
Compare
|
/test |
4c6e4d4 to
1856f82
Compare
|
/test |
christarazi
approved these changes
May 7, 2024
pippolo84
approved these changes
May 8, 2024
youngnick
approved these changes
May 9, 2024
marseel
reviewed
May 9, 2024
1856f82 to
d0ee2a7
Compare
Add ClientBuilderCell to Cilium Operator's client package, which provides a ClientBuilderFunc that can be used to create a new Clientset for a controller. This allows decoupling the various controllers from the main Clientset used by the operator. Additionally, add support for optionally specifying a user agent when creating a new Clientset. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
d0ee2a7 to
d7abb44
Compare
Create a new Clientset for the CiliumEndpointSlice controller using the ClientBuilderFunc to decouple it from the other controllers. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
d7abb44 to
88933c2
Compare
marseel
approved these changes
May 9, 2024
|
/test |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple the CiliumEndpointSlice controller from the main operator Clientset to prevent it from saturating the rate limit and affecting other controllers.
The 1st commit introduces a new Hive Cell to provide a
ClientBuilderFunc, which can be executed by a controller to retrieve a new Clientset. The 2nd commit utilizes theClientBuilderFuncin the CiliumEndpointSlice controller to create a new Clientset